Refs #38 - Tag system - Githubissues

labcodes / knowledge

2 stars 0 forks source link

Refs #38 - Tag system #40

Closed alessandroHenrique closed 7 years ago

alessandroHenrique commented 7 years ago

Link to task: https://github.com/labcodes/knowledge/issues/38 How to test:

Run pip install -r requirements.txt
Run python manage.py migrate
Try adding a new link with tags in the webapp
Try adding a new link with tags from slack using the syntax "/knowledge link tag, tag, tag"

When a tag does not exist, the follow error message appears: new_error_message

renatooliveira commented 7 years ago

I didn't like the design. I think we could follow bootstrap cards to display the links.

Tags should be clickable, going to a page where we filter links by that tag

alessandroHenrique commented 7 years ago

@renatooliveira Take a look now, I made the tweaks in the layout

alessandroHenrique commented 7 years ago

@renatooliveira All done!

renatooliveira commented 7 years ago

Hey, I think that a better message here would be "There is no link with that tag" and yellow. I felt like I did something wrong with this red message.

renatooliveira commented 7 years ago

hey @alessandroHenrique, quick fix

alessandroHenrique commented 7 years ago

@renatooliveira Fixed!

fix_tags