codecov[bot]
commented
4 years ago Codecov Report
Merging #103 into master will increase coverage by
0.25%. The diff coverage is90.52%.
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 69.95% 70.21% +0.25%
==========================================
Files 147 147
Lines 27125 27222 +97
==========================================
+ Hits 18976 19114 +138
+ Misses 8149 8108 -41 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/commercetools/_schemas/_me.py | 0.00% <0.00%> (ø) |
|
| src/commercetools/_schemas/_message.py | 75.88% <0.00%> (ø) |
|
| src/commercetools/_schemas/_product_discount.py | 80.47% <0.00%> (+1.90%) |
:arrow_up: |
| src/commercetools/_schemas/_product_type.py | 78.77% <0.00%> (+0.55%) |
:arrow_up: |
| src/commercetools/_schemas/_project.py | 80.29% <0.00%> (+0.72%) |
:arrow_up: |
| src/commercetools/_schemas/_subscription.py | 79.38% <0.00%> (ø) |
|
| src/commercetools/helpers.py | 81.33% <ø> (+9.33%) |
:arrow_up: |
| src/commercetools/protocols.py | 0.00% <ø> (ø) |
|
| src/commercetools/testing/categories.py | 100.00% <ø> (ø) |
|
| src/commercetools/testing/customer_groups.py | 100.00% <ø> (ø) |
|
| ... and 77 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 72e0f4c...5951427. Read the comment docs.
Previously all properties were marked as either optional or required based on the raml specification. The init method of the types were however always optional since the default value of None was defined.
This commit re-orders the keyword arguments and removes default values for required values. This means that all values which are required should be specified when creating the instance.
Note that this is a backwards incompatible change
TODO: