Initial rmf-codegen generated codebase

labd / commercetools-python-sdk

Commercetools Python SDK

https://commercetools-python-sdk.readthedocs.io/en/latest/

MIT License

17 stars 16 forks source link

Initial rmf-codegen generated codebase #113

Closed mvantellingen closed 3 years ago

mvantellingen commented 3 years ago

New codebase generated on https://github.com/labd/rmf-codegen/tree/feature/python

Todo:

[x] Handle regex query parameters
[x] Validate image upload calls
[x] Make sure that subtypes are returned from supertype deserialization
[x] Decide if we want to convert camel case request builder properties to snake case

To be done later:

[ ] Convert more unittests to new client (later s
[ ] Generate error handling based on raml

davidweterings commented 3 years ago

Very nice :^), looked through various file and don't see a lot of issues.

We can remove the 'from commercetools.helpers import RemoveEmptyValuesMixin' import?
Is there a way we can fix the typing for the response_class?

Looks that way on both python 3.7 and 3.9

mvantellingen commented 3 years ago

Very nice :^), looked through various file and don't see a lot of issues.

We can remove the 'from commercetools.helpers import RemoveEmptyValuesMixin' import? Oops :-)

Is there a way we can fix the typing for the response_class?

So i initially created it using the typing.Protocol() since we just require a deserialize classmethod and a serialize method, but that is only working with 3.8. Will test typing.Type[Model]

Looks that way on both python 3.7 and 3.9