search

labd / commercetools-python-sdk

Commercetools Python SDK
https://commercetools-python-sdk.readthedocs.io/en/latest/
MIT License
17 stars 16 forks source link

Auto generate services #96

Closed mvantellingen closed 4 years ago

mvantellingen commented 4 years ago

Automatically create the commercetools service endpoints based on the raml specs. This should be backwards compatible

codecov[bot] commented 4 years ago

Codecov Report

Merging #96 into master will decrease coverage by 0.24%. The diff coverage is 62.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
- Coverage   73.25%   73.01%   -0.25%     
==========================================
  Files         140      149       +9     
  Lines       26568    26959     +391     
==========================================
+ Hits        19463    19683     +220     
- Misses       7105     7276     +171
Impacted Files Coverage Δ
src/commercetools/exceptions.py 56.66% <ø> (ø)
src/commercetools/services/custom_object.py 0.00% <0.00%> (ø)
src/commercetools/testing/abstract.py 91.43% <ø> (ø)
src/commercetools/helpers.py 68.50% <28.57%> (-2.33%) :arrow_down:
src/commercetools/services/me.py 38.53% <38.53%> (ø)
src/commercetools/services/in_stores.py 39.81% <39.81%> (ø)
src/commercetools/services/subscriptions.py 51.35% <43.47%> (-15.32%) :arrow_down:
src/commercetools/services/types.py 56.75% <44.44%> (+16.37%) :arrow_up:
src/commercetools/services/product_discounts.py 55.00% <48.00%> (+2.22%) :arrow_up:
src/commercetools/services/zones.py 51.35% <51.35%> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 70c7e06...d2b6068. Read the comment docs.

mvantellingen commented 4 years ago
  • We're formatting strings in a couple of different ways (f.e. service_processor.py); should we use f-strings where possible?

Fixed a couple of cases. However for readability I've sometimes kept other formatting styles (e.g. dict items in f-strings)

  • For DTC (and GD) we've decided to not use import typing but make it explicit (since this is also what Python itself uses in their own documentation). It does make code easier to generate.

Not sure what you mean with this. Leaving typing.py out of it makes it implicit instead of explicit right?