search

labd / django-cognito-jwt

An Authentication backend for Django Rest Framework for AWS Cognito JWT tokens
MIT License
179 stars 59 forks source link

Cache JWKS response from Cognito #10

Closed joshkersey closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #10 into master will decrease coverage by 1.25%. The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage     100%   98.75%   -1.25%     
==========================================
  Files           3        3              
  Lines          75       80       +5     
  Branches        7        8       +1     
==========================================
+ Hits           75       79       +4     
- Partials        0        1       +1
Impacted Files Coverage Δ
src/django_cognito_jwt/backend.py 100% <100%> (ø) :arrow_up:
src/django_cognito_jwt/validator.py 97.56% <83.33%> (-2.44%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0c15385...07a5574. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #10 into master will decrease coverage by 1.25%. The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage     100%   98.75%   -1.25%     
==========================================
  Files           3        3              
  Lines          75       80       +5     
  Branches        7        8       +1     
==========================================
+ Hits           75       79       +4     
- Partials        0        1       +1
Impacted Files Coverage Δ
src/django_cognito_jwt/backend.py 100% <100%> (ø) :arrow_up:
src/django_cognito_jwt/validator.py 97.56% <83.33%> (-2.44%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0c15385...07a5574. Read the comment docs.

aramboi commented 5 years ago

Caching support was added in PR https://github.com/labd/django-cognito-jwt/pull/12. I think this can be closed as it duplicates functionality.

mikedebock commented 5 years ago

Thank you for your contribution! We just released 0.0.2 with caching support.