Closed MichelML closed 2 years ago
@mvantellingen @mikedebock can you please check and merge, and publish a new patch or minor when this is done please
without this it's impossible to upgrade to django-4
@mikedebock do you have the rights to merge this? You seem more active compared to the initial maintainer @mvantellingen
hello @mikedebock , sorry to push for that, this is a minor PR and I can see you are active on GH - do you guys plan on making any additional change/maintenance on this package or not?
good morning @mikedebock @mvantellingen , it would just be nice to have an answer from you guys.
Thanks in advance :pray:
Hi @MichelML,
Thank you for your pull request. I've a small finding, would you process my small feedback? After that I'll merge this PR en check out if i'm able to create a new release for you!
Thanks @mikedebock , this is fixed :+1: please let me know of any updates
@mikedebock seems unclear to me at the moment wether the failing UTs are because of this change https://github.com/labd/django-cognito-jwt/runs/4486077441?check_suite_focus=true
there seems to be a formatting issue also, sorry for that
@MichelML I've fixed the formatting error, but the build is still failing. I think because of outdated (not-pinned) dependencies.
Can you take care of succeeding the build? You can check this locally by running: pip install tax && tox -e py38-django30
looking into it
@mikedebock you can check this PR which is ready to be merged I think https://github.com/labd/django-cognito-jwt/pull/41
@MichelML looks like the credentials of pypi are invalid, I'm on int!
see https://github.com/labd/django-cognito-jwt/issues/39