labd / django-cognito-jwt

An Authentication backend for Django Rest Framework for AWS Cognito JWT tokens
MIT License
177 stars 59 forks source link

Replace ugettext and smart_text with proper functions for Django 4 compatibility #40

Closed MichelML closed 2 years ago

MichelML commented 2 years ago

see https://github.com/labd/django-cognito-jwt/issues/39

MichelML commented 2 years ago

@mvantellingen @mikedebock can you please check and merge, and publish a new patch or minor when this is done please

without this it's impossible to upgrade to django-4

MichelML commented 2 years ago

@mikedebock do you have the rights to merge this? You seem more active compared to the initial maintainer @mvantellingen

MichelML commented 2 years ago

hello @mikedebock , sorry to push for that, this is a minor PR and I can see you are active on GH - do you guys plan on making any additional change/maintenance on this package or not?

MichelML commented 2 years ago

good morning @mikedebock @mvantellingen , it would just be nice to have an answer from you guys.

Thanks in advance :pray:

mikedebock commented 2 years ago

Hi @MichelML,

Thank you for your pull request. I've a small finding, would you process my small feedback? After that I'll merge this PR en check out if i'm able to create a new release for you!

MichelML commented 2 years ago

Thanks @mikedebock , this is fixed :+1: please let me know of any updates

MichelML commented 2 years ago

@mikedebock seems unclear to me at the moment wether the failing UTs are because of this change https://github.com/labd/django-cognito-jwt/runs/4486077441?check_suite_focus=true

there seems to be a formatting issue also, sorry for that

mikedebock commented 2 years ago

@MichelML I've fixed the formatting error, but the build is still failing. I think because of outdated (not-pinned) dependencies. Can you take care of succeeding the build? You can check this locally by running: pip install tax && tox -e py38-django30

MichelML commented 2 years ago

looking into it

MichelML commented 2 years ago

@mikedebock you can check this PR which is ready to be merged I think https://github.com/labd/django-cognito-jwt/pull/41

mikedebock commented 2 years ago

@MichelML looks like the credentials of pypi are invalid, I'm on int!