labd / django-cognito-jwt

An Authentication backend for Django Rest Framework for AWS Cognito JWT tokens
MIT License
177 stars 59 forks source link

fix pyjwt version #41

Closed MichelML closed 2 years ago

MichelML commented 2 years ago

ref https://github.com/flavors/django-graphql-jwt/issues/242 ref https://stackoverflow.com/questions/65757394/module-jwt-has-no-attribute-expiredsignature

image

@mikedebock the wrong pyjwt version was the only issue I found breaking the build, see ref above (it's also unrelated to my changes)

related PR https://github.com/labd/django-cognito-jwt/pull/40

MichelML commented 2 years ago

wait before merging this please, looking at other PRs I don't think this is the way to go officially

MichelML commented 2 years ago

@mikedebock I think this is good, I formatted and took in consideration older PRs (which can be closed now)

https://github.com/labd/django-cognito-jwt/pull/38 https://github.com/labd/django-cognito-jwt/pull/37

tests pass in all environments too

mikedebock commented 2 years ago

Thank you for your contribution @MichelML !

MichelML commented 2 years ago

my pleasure @mikedebock , if you can close the other two issues and publish a new version, it would be appreciated :pray:

MichelML commented 2 years ago

the two PRs, sorry :D #38 and #37 can be closed

MichelML commented 2 years ago

@mikedebock you can also close #34 as this PR adresses the issue

MichelML commented 2 years ago

@mikedebock once last thing, it seems the release didn't work https://github.com/labd/django-cognito-jwt/runs/4487961949?check_suite_focus=true

maybe an expired token or auth creds?

mikedebock commented 2 years ago

@MichelML I'm on it, checking at my colleagues for a new token.

mikedebock commented 2 years ago

@MichelML 0.0.4 is available: https://pypi.org/project/django-cognito-jwt/

MichelML commented 2 years ago

Awesome!!!!

MichelML commented 2 years ago

Thanks a lot for the support @mikedebock

mikedebock commented 2 years ago

You're welcome! Thank you for your contribution @MichelML !