Closed MichelML closed 2 years ago
wait before merging this please, looking at other PRs I don't think this is the way to go officially
@mikedebock I think this is good, I formatted and took in consideration older PRs (which can be closed now)
https://github.com/labd/django-cognito-jwt/pull/38 https://github.com/labd/django-cognito-jwt/pull/37
tests pass in all environments too
Thank you for your contribution @MichelML !
my pleasure @mikedebock , if you can close the other two issues and publish a new version, it would be appreciated :pray:
the two PRs, sorry :D #38 and #37 can be closed
@mikedebock you can also close #34 as this PR adresses the issue
@mikedebock once last thing, it seems the release didn't work https://github.com/labd/django-cognito-jwt/runs/4487961949?check_suite_focus=true
maybe an expired token or auth creds?
@MichelML I'm on it, checking at my colleagues for a new token.
@MichelML 0.0.4 is available: https://pypi.org/project/django-cognito-jwt/
Awesome!!!!
Thanks a lot for the support @mikedebock
You're welcome! Thank you for your contribution @MichelML !
ref https://github.com/flavors/django-graphql-jwt/issues/242 ref https://stackoverflow.com/questions/65757394/module-jwt-has-no-attribute-expiredsignature
@mikedebock the wrong pyjwt version was the only issue I found breaking the build, see ref above (it's also unrelated to my changes)
related PR https://github.com/labd/django-cognito-jwt/pull/40