labd / django-cognito-jwt

An Authentication backend for Django Rest Framework for AWS Cognito JWT tokens

MIT License

177 stars 59 forks source link

Return 401 response for failed authentication attempts. #7

Closed umgelurgel closed 5 years ago

umgelurgel commented 5 years ago

As per the docucumentation, the authentication backend has to define an authenticate_header method for it to return 401 response for failed authentication attempts. Otherwise a 403 response is returned.

codecov[bot] commented 5 years ago

Codecov Report

Merging #7 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master     #7   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          73     75    +2     
  Branches        7      7           
=====================================
+ Hits           73     75    +2

Impacted Files	Coverage Δ
src/django_cognito_jwt/backend.py	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4f582fb...127b76b. Read the comment docs.

umgelurgel commented 5 years ago

@mvantellingen would it be possible to get this merged and have a new version deployed to pypi?

pimvernooij commented 5 years ago

Hi @umgelurgel

Pypi release will follow soon, apologies for the late response :)

Best, Pim

umgelurgel commented 5 years ago

Thanks @pimvernooij ! And thanks for your work on this package, it's been very helpful - looking forward to the pypi release! :)

mikedebock commented 5 years ago

Hi @umgelurgel,

A little bit later then expected, but we just released 0.0.2.

Mike

umgelurgel commented 5 years ago

Awesome! Thanks for letting me know @mikedebock and for your work on this project!