Update `oscar_wagtail` to the last versions of Oscar and Wagtail

labd / django-oscar-wagtail

Wagtail integration for Oscar Commerce (or Oscar Commerce integration for Wagtail?)

MIT License

101 stars 33 forks source link

Update `oscar_wagtail` to the last versions of Oscar and Wagtail #9

Closed samitnuk closed 5 years ago

samitnuk commented 5 years ago

Test with Python 2.7 failed, since Wagtail > 2.0 does not support it.

pjstevns commented 5 years ago

Hi,

Dropping support for python2 seems reasonable. This should be reflected in the tox.ini file.

What I don't understand is the reason behind pinning to to latest versions of wagtail and oscar. Versions in setup.py should be the minimum required versions. Doing otherwise will prevent people from installing this package in say wagtail 2.0 even though the package is perfectly compatible.

Finally, workflow specific exclusions do not belong in .gitignore but in your local .git/info/exclude.

samitnuk commented 5 years ago

@pjstevns

Thanks for your comments! I will modify this PR.

samitnuk commented 5 years ago

@pjstevns

I updated this PR. Please review and comment. Thanks!