labd / terraform-provider-commercetools

Terraform provider for commercetools
https://registry.terraform.io/providers/labd/commercetools/latest/docs
Mozilla Public License 2.0
65 stars 70 forks source link

Proposal: Allow to adjust token validity for Api Clients via Terraform #539

Open mlitvinav opened 1 week ago

mlitvinav commented 1 week ago

The API Clients allow to override the default token validity but this is only possible during the creation of the api client.

While the access_token's are valid for 48 hours, the lifetime of refresh_tokens is 200 days, which is pretty high. I would like to be able to set custom validity values for the api clients. Especially because there is no way to update existing clients, so after creation hooks wont work here.

NEW FEATURES | UPGRADE NOTES | ENHANCEMENTS | BUG FIXES | EXPERIMENTS

Extends resource_api_client to read and write the fields accessTokenValiditySeconds and refreshTokenValiditySeconds.


Please double check if these changes are good to go. It seems there is not much that needs to be changed but i am unfamiliar with Go and working with TF providers.