search

labdao / plex

Platform for running comp bio applications on distributed compute and storage infrastructure
https://lab.bio
MIT License
54 stars 14 forks source link

s3client instantiation update for getObject #999

Closed supraja-968 closed 1 month ago

supraja-968 commented 1 month ago

What type of PR is this?

Description

Fixing s3 client instantiations in queue.go and checkpoints.go. In this PR, I removed all the cyclic imports and introduced an optional bool input parameter to the NewS3Client() method in s3.go. so we manage the presigned URL properly for checkpoints alone, while leaving it undisturbed in every other instances.

Note: In addition to these, the fileHash column in files table is now an optional column. It is only populated for user uploaded files and models. Not for experiment generated files, as we don't require a hash for these output files.

A successful experiment page: https://test-app.lab.bio/experiments/21 image

Steps to Test

A successful test should show downloadable output files in the RAW FILES tab and checkpoints in the molstar viewer.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **docs** | ⬜️ Ignored ([Inspect](https://vercel.com/convexitylabs/docs/Frzsv7Vpdpxx2McxUf3F17LPTHwH)) | [Visit Preview](https://docs-git-hashs3-patch-convexitylabs.vercel.app) | | Jul 18, 2024 1:56pm |