labeleven-dev / bettercallsol

The missing Solana client
https://bettercallsol.dev
Apache License 2.0
50 stars 6 forks source link

fix(borsh): truncated borsh encoded instruction data to layout length #81

Closed sohrab- closed 2 years ago

sohrab- commented 2 years ago

Bug: if there are no borsh instruction data fields, the instruction data is not truncated

https://bettercallsol.dev?share=https://gist.githubusercontent.com/steveluscher/791d2d45c4b72bba8d60e9c0ffb2ba11/raw/6c9a560a86a6082c1de7bc039b947c6e5d4c5f04/gistfile1.txt

https://explorer.solana.com/tx/inspector?cluster=devnet&message=AQAHCJFtsjW%252Foq0UUbqcgynwT3n9ALUU5CDq8peARijFip74YouNTyRotsHmkLSwmk9zi25LSsCXwRZK9VeIMAVy%252BSN5wCDrUq9OBmz8SED6WuD%252Bxkwlb3w8BvH%252FUP96QpAuVolxv343VLRVOmHS1L0CKmEfRcPr4GMr8rFXMAp9P76KjJclj04kifG7PRApFI4NgwtaE5na%252FxCEBI572Nvp%252BFmx1eLp5leQPNlXVeA1PELSDdywYAqVuis0l357IeTB9Aan1RcZLFxRIYzJTD1K8X9Y2u4Im6H9ROPb2YoAAAAABt324ddloZPZy%252BFGzut5rBy0he1fWzeROoz1hX7%252FAKnIy3bDF8TyAYGFpjBsH4q%252Fpd3Po56EI%252FRciEfQClvGYgEFBwACAwEEBgfwBwuTs7KRdi26AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA%253D%253D

github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit 0f19503):

https://bcsol-a8522--pr81-fix-borsh-length-hi255un2.web.app

(expires Tue, 13 Sep 2022 01:49:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.0.0-alpha.51 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: