search

labelle-org / labelle

Label printing software
Apache License 2.0
27 stars 4 forks source link

Clean up barcodes #25

Closed maresb closed 3 months ago

maresb commented 4 months ago

This should be a case study for how not to do object-oriented programming.

It's as if someone took a perfectly reasonable function and asked, "Ok, how can we maximally obfuscate this so that nobody can figure out how it works? Oh, I know, we can add a bunch of unnecessary global state, and make the control flow nondeterministic."

maresb commented 4 months ago

(No content changes, just a fresh rebase on main.)

tomers commented 3 months ago

@maresb, I leave it for you to merge. This is a big change, so I think you should handle it, as you wrote it.

maresb commented 3 months ago

Let's merge #32 first. I checked these changes by hand, but it'll be great to be sure I didn't miss anything.