Closed FaBjE closed 2 months ago
This is really amazing work @FaBjE, thanks so much for the contribution!!!
@maresb Did you test your fix? I'm not sure (and cant test it atm), but I think the argument needs to be quoted on the commandline (when vs code is starting docker) because it contains spaces. The outer quotes are for the JSON. the single '
inner quotes were for the commandline.
Ya, I tested it. My fix is consistent with the link you provided in combination with the way shells process arguments. When you write 'c 189:* rw'
in a shell, the shell parses it so that it is a single argument rather than c
, 189:*
, rw
. When specifying arguments as a JSON list, each list element becomes a single unquoted argument. Before my fix, the quotation marks were interpreted as part of the argument itself, not as grouping characters.
Shells (especially Bash) are weird.
Ah good to know! I always get confused with shells, quotation and especially when providing the input via a 3rd party like the JSON. Oddly enough it worked for me with the quotes, but It's always better to do it the proper way 😃
Strange, it was broken for me before the fix. But dev containers can be very finicky.
I've made some changes to the dev container/environment Two small, one big.
Small changes:
Big change:
let me know what you think 😃