labelmeai / labelme

Image Polygonal Annotation with Python (polygon, rectangle, circle, line, point and image-level flag annotation).
https://labelme.io
Other
13.11k stars 3.37k forks source link

Optimize the brightness contrast adjustment #1443

Closed PairZhu closed 2 months ago

PairZhu commented 3 months ago

Specify the encoding parameters of open to be compatible with more operating systems (such as windows) in get_long_description Unify the naming style of variables, add specific numerical display labels, and speed up the response speed of adjustments (especially for large images)

wkentaro commented 2 months ago

what error do you get on windows from get_long_description ?

wkentaro commented 2 months ago

what error do you get on windows from get_long_description ?

Merging this PR without this for now.

Please open a new one if need

PairZhu commented 2 months ago

what error do you get on windows from get_long_description ?

I did not test other language versions of windows systems, at least in the Chinese version, the default encoding of python's open function is' gbk'

wkentaro commented 2 months ago

you can't install due to that?

PairZhu commented 2 months ago

you can't install due to that?

I can't

wkentaro commented 2 months ago

I see. The Windows in CI is passing, so curious to know why.

Can you give me some print of your encoding and the error message?

PairZhu commented 2 months ago

I see. The Windows in CI is passing, so curious to know why.

Can you give me some print of your encoding and the error message?

PS C:\Users\11153\Documents\Code\GitHub\labelme> pip install -e .
Looking in indexes: https://pypi.tuna.tsinghua.edu.cn/simple
Obtaining file:///C:/Users/11153/Documents/Code/GitHub/labelme
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [12 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "C:\Users\11153\Documents\Code\GitHub\labelme\setup.py", line 160, in <module>
          main()
        File "C:\Users\11153\Documents\Code\GitHub\labelme\setup.py", line 123, in main
          long_description=get_long_description(),
                           ^^^^^^^^^^^^^^^^^^^^^^
        File "C:\Users\11153\Documents\Code\GitHub\labelme\setup.py", line 73, in get_long_description
          long_description = f.read()
                             ^^^^^^^^
      UnicodeDecodeError: 'gbk' codec can't decode byte 0x97 in position 698: illegal multibyte sequence
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.