search

laberning / openrowingmonitor

A free and open source performance monitor for rowing machines
https://laberning.github.io/openrowingmonitor
GNU General Public License v3.0
99 stars 19 forks source link

Added heartrate to TCX dummy, also some code cleanup #17

Closed JaapvanEkris closed 3 years ago

JaapvanEkris commented 3 years ago

Added heartrate data to the TCX dummy Code cleanup (renaming some variables, also cleaned up the interface with the moving flank detector)

JaapvanEkris commented 3 years ago

Hi Lars,

No problem, I am working on a version with better noise filtering that I will commit to the latest branch using a running average. I tested it with a bunch of my runs, and the results look pretty good (the power and stroke rate seem to be less unstable). The names were already in my code, I didn't notice that you changed them as well :) We'll stick with your naming then.

I did a reverse pull from the main branch last Sunday, to bring everything back in sync. Seems odd that I still are tossing allong the baggage of all previous commits. I'll fork a new branch from the main branch.

Jaap