labexp / osmtracker-android

GPS tracking tool for OpenStreetMap
GNU General Public License v3.0
503 stars 237 forks source link

setting a WPT should also create a TRKPT #187

Open icrf2000 opened 5 years ago

icrf2000 commented 5 years ago

If one sets a waypoint, this should also create a trackpoint at the same time. Otherwise, the waypoints are "dangling around". When watching the track, you wonder "how did I get there at all".

EmmanuelAB commented 5 years ago

We are not sure if you're trying to add the gps point (lat,long) in both lists of waypoints and trackpoints. Could you update this PR to see only the changes made to fix the issue ?

icrf2000 commented 5 years ago

The original commit was e91b61c, branching from upstream 1ee6840 (v0.7.1) on Feb. 19. The diff at this time was simply:

diff --git a/app/src/main/java/net/osmtracker/service/gps/GPSLogger.java b/app/src/main/java/net/osmtracker/service/gps/GPSLogger.java
index 480a710..7be81c6 100644
--- a/app/src/main/java/net/osmtracker/service/gps/GPSLogger.java
+++ b/app/src/main/java/net/osmtracker/service/gps/GPSLogger.java
@@ -121,8 +121,6 @@ public class GPSLogger extends Service implements LocationListener {
                            String link = extras.getString(OSMTracker.INTENT_KEY_LINK);

                            dataHelper.wayPoint(trackId, lastLocation, lastNbSatellites, name, link, uuid, sensorListener.getAzimuth(), sensorListener.getAccuracy());
-                           // If there is a waypoint in the track, there should also be a trackpoint
-                           dataHelper.track(currentTrackId, lastLocation, sensorListener.getAzimuth(), sensorListener.getAccuracy());
                        }
                    }
                }

In the meantime, there seem to be many merge conflicts. Cherry-picking e91b61 into develop still works however. I could create a new PR, that would probably be the easiest?