labgem / PPanGGOLiN

Build a partitioned pangenome graph from microbial genomes
https://ppanggolin.readthedocs.io
Other
242 stars 29 forks source link

a few minor code changes #259

Closed fchapoton closed 2 months ago

fchapoton commented 3 months ago

:fr:

juste quelques petits details

plus suppression des lignes de declaration d'encodage utf8, inutiles

:gb:

The utf-8 encoding is now the default in python since python3, so there is no need to declare that in every file.

Using yield from is recommended as much better by pep 0380 (https://peps.python.org/pep-0380/).

IOError is now an alias for OSError.

Some of the changes were scripted using the very fast linter ruff, see the section UP in its documentation : https://docs.astral.sh/ruff/rules/#pyupgrade-up and in particular UP009 and UP024.

jpjarnoux commented 2 months ago

Hi!

Thanks for your contribution.

Could you please update your description with more details and translate it into English? What I meant by more details is:

We found some information that justifies your change, but it would be better if it came from you.

Thanks again, and regards

JeanMainguy commented 2 months ago

Thank you for the update of the description 👌