labgrid-project / labgrid

Embedded systems control library for development, testing and installation
https://labgrid.readthedocs.io/
Other
327 stars 164 forks source link

docs: Failed to build PDF #1353

Open sjg20 opened 5 months ago

sjg20 commented 5 months ago

make help shows:

  latexpdf    to make LaTeX and PDF files (default pdflatex)

but using make latexpdf fails. In fact it seems to hang in latex somewhere:

[25] [26] [27] [28]
Chapter 4.
[29] [30] [31] [32] [33] [34] [35] [36] [37] [38] [39] [40]
Chapter 5.

! LaTeX Error: Unknown graphics extension: .svg.

See the LaTeX manual or LaTeX Companion for explanation.
Type  H <return>  for immediate help.
 ...                                              

l.2628 ...dth=0.500\linewidth]{{config_graph}.svg}

? 

! LaTeX Error: Unknown graphics extension: .svg.

See the LaTeX manual or LaTeX Companion for explanation.
Type  H <return>  for immediate help.
 ...                                              

l.2628 ...dth=0.500\linewidth]{{config_graph}.svg}

?
Emantor commented 4 months ago

Looks like this fails since we integrated svg files, we'll need to modify the sphinx config to include the image converter extension which will automatically convert to png for pdf creation.

jluebbe commented 4 months ago

We could also just disable PDF completely. Is there a need for them with online and offline HTML docs?

Bastian-Krause commented 4 months ago

Btw, RTD also generates pdf documentation for releases: https://readthedocs.org/projects/labgrid/downloads/

sjg20 commented 4 months ago

PDFs are helpful for printing a proper doc with page numbers, TOC, index

sjg20 commented 4 months ago

BTW do web browsers support SVG now? I certainly see some pages that contain them