search

labgrid-project / labgrid

Embedded systems control library for development, testing and installation
https://labgrid.readthedocs.io/
Other
315 stars 163 forks source link

Timeout Parameter for "labgrid-client reserve" #1415

Open hbml opened 1 month ago

hbml commented 1 month ago

In our GitLab CI workflows, we encounter issues with tests running longer than expected, leading to job timeouts and unintended interruptions. We propose adding a timeout parameter to the labgrid-client reserve command.

Adding a timeout parameter to the labgrid-client reserve command (e.g., 1 hour) to ensure ample time to run tests and restore the test environment.

Thank you for considering this enhancement.

jluebbe commented 4 weeks ago

I'd like to understand your case better. Other running test keep the places locked longer than expected? If those other tests are stalled, perhaps it would be better to abort that test run and let the waiting reservation continue?

We're currently reworking the coordinator to use gRPC: https://github.com/labgrid-project/labgrid/discussions/1417 Based on that code, it should be easy to abort after a timeout expires: https://github.com/labgrid-project/labgrid/blob/grpc/labgrid/remote/client.py#L1443 (in the _wait_reservation function).