search

labgrid-project / labgrid

Embedded systems control library for development, testing and installation
https://labgrid.readthedocs.io/
Other
343 stars 179 forks source link

ssh options typo ? #1503

Closed josepee closed 2 months ago

josepee commented 2 months ago

Hi again,

looking into the code of labgrid/util/ssh.py, in _start_own_master, in the ssh otpion arguments, i see this:

# We don't want to ask the user to confirm host keys here.
"-o", "StrictHostKeyChecking=yes",

is it a typo and you meant no ? Or just meant that there shouldn't be a prompt to fill in but the key should be known ?

Emantor commented 2 months ago

What the comment means is that we want to user to have already logged into the machine, otherwise we error out. This is necessary since we can't handle the confirmation prompt within labgrid and want the code to return an error in this case.

josepee commented 2 months ago

ok so i have to connect once by hand to the ssh server and then i can use it freely

Emantor commented 2 months ago

Yes, this is the idea.

josepee commented 2 months ago

ok thank you :pray: