Feature: labgrid-client ssh to use NetworkService if available

labgrid-project / labgrid

Embedded systems control library for development, testing and installation

https://labgrid.readthedocs.io/

Other

334 stars 174 forks source link

Closed andreasdotzler closed 5 years ago

andreasdotzler commented 6 years ago

labgrid-client ssh currently requires labgrid.resource.base.EthernetPort available for the target. It should use NetworkService if available.

jluebbe commented 6 years ago

Yes, that seems to be missing from client.py. I'd be happy to merge a PR for this.

Bastian-Krause commented 6 years ago

I implemented this with #342. Please test it.

maximilianriemensberger commented 5 years ago

@Bastian-Krause I tested #342. It will not work with the NetworkService if the port is not 22.

Bastian-Krause commented 5 years ago

@maximilianriemensberger I opened #375 to support NetworkService's port.

I'll close this as @maximilianriemensberger tested this already.