labjack / LabJackPython

The official Python modules and classes for interacting with the LabJack U3, U6, UE9 and U12
https://labjack.com/support/software/examples/ud/labjackpython
MIT License
117 stars 79 forks source link

Rename 'CSPINNum' to 'CSPinNum' for consistency with other kwargs #90

Closed mnaberez closed 8 years ago

mnaberez commented 8 years ago

The CSPINNum keyword argument of spi() is not like the others:

CSPINNum
CLKPinNum
MISOPinNum
MOSIPinNum

This is unintuitive and was probably a typo. This patch renames CSPINNum to CSPinNum. Code using the old CSPINNum name will still work.

davelopez01 commented 8 years ago

I agree with your change. The low-level documentation refers to this setting as CSPinNum as well and likely the CSPINNum naming was by mistake. Thanks for the commit.