search

lablabs / terraform-aws-eks-karpenter

A terraform module to deploy the karpenter on Amazon EKS cluster.
Apache License 2.0
8 stars 3 forks source link

bug: renamed aws.* setting in Karpenter 0.32 #9

Closed petrzjunior closed 1 month ago

petrzjunior commented 3 months ago

Summary

Karpenter Helm chart changed variable names from settings.aws.* to settings.* in 0.32. The renaming scheme in written in the docs: https://karpenter.sh/v0.32/upgrading/v1beta1-migration/#helm-values Reference: https://github.com/aws/karpenter-provider-aws/issues/5366

Issue Type

Bug Report

Terraform Version

Terraform v1.7.4
on linux_amd64

Steps to Reproduce

Install the modue with Karpenter version >= 0.32.

Expected Results

I expect the module to fill e.g. settings.clusterName as the Helm chart expects.

Actual Results

Instead settings.aws.clusterName is used which is not used by the Helm chart. Karpenter console output:

panic: validating options, missing field, cluster-name
dojci commented 1 month ago

Thx for reporting, this will be fixed in the upcoming release https://github.com/lablabs/terraform-aws-eks-karpenter/pull/11

jaygridley commented 1 month ago

Fixed by https://github.com/lablabs/terraform-aws-eks-karpenter/releases/tag/v2.0.0