Indexed 'ssh' file prevents putty-launcher from activating

[GoogleCodeExporter]

What steps will reproduce the problem?

1. Configure Launchy to scan a directory containing a watched file named
"ssh.*" or "putty.*", such as ssh.exe (this problem was originally observed
when scanning c:\Program Files for .exe files, with OpenSSH installed).
2. Rebuild Launchy index and restart Launchy.
3. Type: 'ssh<tab>' and notice that putty-launcher is not activated.

What is the expected output?

putty-launcher to override any 'ssh' or 'putty' user input.

What do you see instead?

Indexed 'ssh' or 'putty' files prevent putty-launcher from activating.

What version of the product are you using? On what operating system?

putty-launcher 1.2 and Launchy 1.25

Please provide any additional information below.

Original issue reported on code.google.com by jeff.thi...@gmail.com on 6 Nov 2007 at 7:40

[GoogleCodeExporter]

Duplicate of issue #2.  This is a bug with Launchy, not with the plugin.  If 
you can
figure out a solution, that would be great.  The only solution is to rename your
other shortcut.  I could add another keyword, but still, launchy should be 
fixed.

Original comment by matthew....@gmail.com on 6 Nov 2007 at 10:13

• Changed state: Duplicate

[GoogleCodeExporter]

Sorry for the dup - I didn't notice the filter was only showing open issues.

A couple of ideas:  

1. Add a textbox to the options dialog that allows the user to specify the
keyword(s).  It would be a little weird since you need both the regex and the 
plain
string for PluginGetIdentifiers(), but you could build up the case-insensitive 
regex
without too much difficulty.

2. I haven't tested this, but are you sure you are calling makeResult() in
PluginGetIdentifiers() correctly?  According to the API, it seems like you need 
to
pass something other than an empty string for the 2nd and 3rd arguments.  Also 
see
the Runny example
http://launchy.svn.sourceforge.net/viewvc/launchy/trunk/Launchy_VC7/Plugins/Runn
y/Runny.cpp?revision=165&view=markup).

Original comment by jeff.thi...@gmail.com on 7 Nov 2007 at 4:49

[GoogleCodeExporter]

Here is the patch I used to resolve this issue.  It fixes the problem that 
occurs
when there is a "putty" or "ssh" indexed file, but there still is some odd 
display
behavior (probably the same problem as reported in issue #3).

Original comment by jeff.thi...@gmail.com on 10 Nov 2007 at 10:41

Attachments:

• putty.patch

[GoogleCodeExporter]

I looked at your patch and it creates new issues.  If you have a shortcut which
starts with ssh or putty (such as puttygen) indexed, you will not be able to 
launch
it due to your new regexes.  As for the other two changes: "NumStrings == 0" 
will
disable the search by keyword functionality if the plugin was activated using a
regex, and the change to PluginGetIdentifiers is unnecessary (the first 
argument is
automatically used as the second since none is passed, and it does not have a 
valid
'location' for the third argument).

The current solution is to not use tab completion of 'putty' or 'ssh', and to 
simply
type a ' ' after one of these keywords.  This will activate the regex match 
mode.

This issue also happens with other plugins such as Webby (try creating a 
shortcut
called Google or Amazon -- the shortcut will be used instead of webby) and Runny
(create a command called "Notepad" (note the case)).  There are currently 
several
issues in the Launchy bug database which are the result of this problem:
http://sourceforge.net/tracker/index.php?func=detail&aid=1705729&group_id=132975
&atid=725839
http://sourceforge.net/tracker/index.php?func=detail&aid=1685699&group_id=132975
&atid=725839
http://sourceforge.net/tracker/index.php?func=detail&aid=1642593&group_id=132975
&atid=725839

I will look into adding customizable keywords like in runny, but since there is 
a
workaround (using space instead of tab), it's not high priority.

Original comment by matthew....@gmail.com on 16 Nov 2007 at 5:03

• Added labels: Priority-Low
• Removed labels: Priority-Medium