fix: `onChangeAliasMap` is triggered on every render

lablup / backend.ai-webui

Backend.AI Web UI for web / desktop app (Windows/Linux/macOS). Backend.AI Web UI provides a convenient environment for users, while allowing various commands to be executed without CLI. It also provides some visual features that are not provided by the CLI, such as dashboards and statistics.

GNU Lesser General Public License v3.0

93 stars 66 forks source link

This PR resolves #2368. This is a side effect of https://github.com/lablup/backend.ai-webui/pull/2359

Before this PR, VFolderTable was triggering onChangeSelectedRowKeys on every render if the parent component passed selectedRowKeys as a new instance of an array. VFolderTable should consider this scenario.

Checklist: (if applicable)

[ ] Mention to the original issue
[ ] Documentation
[ ] Minium required manager version
[ ] Specific setting for review (eg., KB link, endpoint or how to setup)
[ ] Minimum requirements to check during review
[ ] Test case(s) to demonstrate the difference of before/after

St.^{:grey_question:}	Category	Percentage	Covered / Total
🔴	Statements	3%	118/3935
🔴	Branches	3.27%	87/2662
🔴	Functions	1.46%	19/1302
🔴	Lines	2.95%	114/3858

St.^{:grey_question:}

lablup / backend.ai-webui

fix: `onChangeAliasMap` is triggered on every render #2370

Coverage report for `./react`

Test suite run success

lablup / backend.ai-webui

fix: `onChangeAliasMap` is triggered on every render #2370

Coverage report for ./react

Test suite run success

Coverage report for `./react`