Closed agatha197 closed 1 month ago
This stack of pull requests is managed by Graphite. Learn more about stacking.
Join @agatha197 and the rest of your teammates on Graphite
./react
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π΄ | Statements | 2.99% (+0% πΌ) |
118/3942 |
π΄ | Branches | 3.25% | 87/2674 |
π΄ | Functions | 1.45% (+0% πΌ) |
19/1307 |
π΄ | Lines | 2.95% (+0% πΌ) |
114/3865 |
32 tests passing in 4 suites.
Report generated by π§ͺjest coverage report action from f808159b73b28ee7ad8375cc80f4fe04711d3c05
TL;DR
This pull request introduces a change to the
onCancel
handling in theServiceLauncherModal
to resolve the issue of the modify service modal popping up when clicking the start service button.What changed?
In the
ServiceListPage
, theonRequestClose
method is called to set theeditingModelService
to null and remove theonCancel
prop.In the
ServiceLauncherModal
, theonCancel
behavior has been changed to callonRequestClose
when triggered.How to test?
resolves https://github.com/lablup/backend.ai-webui/issues/2378
Checklist: (if applicable)