lablup / backend.ai-webui

Backend.AI Web UI for web / desktop app (Windows/Linux/macOS). Backend.AI Web UI provides a convenient environment for users, while allowing various commands to be executed without CLI. It also provides some visual features that are not provided by the CLI, such as dashboards and statistics.
https://www.backend.ai
GNU Lesser General Public License v3.0
110 stars 73 forks source link

add: option to show/hide agent select option by launcher #2870

Closed lizable closed 1 day ago

lizable commented 5 days ago

This PR resolves #2837

Changes: Makes agent selection in resource allocation form configurable via a new enableAgentSelect prop, defaulting to false. The agent selection field will only display when both enableAgentSelect is true and baiClient._config.hideAgents is false.

Implementation:

Testing Steps:

Prerequisites:

  • Create model type vfolder
  • Create model-definition.yaml file and upload it to the vfolder you just created in step 1, according to the link here
    1. Set hideAgents in config.general to false.
    2. Go to Session launcher page and check AgentSelect section is visible.
    3. Check whether you can select agent and create a session which is located to the agent you just selected.
    4. Go to Service launcher page by clicking Start Service button in Serving page and check AgentSelect section is invisible.
    5. Check whether service is successfully created

Checklist:

graphite-app[bot] commented 5 days ago

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

lizable commented 5 days ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions[bot] commented 5 days ago

Coverage report for ./react

St.:grey_question:
Category Percentage Covered / Total
🔴 Statements 5.29% 395/7468
🔴 Branches
4.58% (-0% 🔻)
237/5173
🔴 Functions 3.16% 78/2467
🔴 Lines 5.2% 380/7301

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 3f18c86842ab5c942945f35812d970e415a4c00f

graphite-app[bot] commented 1 day ago

Merge activity