search

laboratoriobridge / bold

https://bold.bridge.ufsc.br
MIT License
76 stars 9 forks source link

[useRovingTabIndex] Eliminate fatal error when cleaning up event listeners #809

Closed mathbalduino closed 1 year ago

mathbalduino commented 1 year ago

closes #806

Hey @lucasjoao , solved it just by adding a local reference, so when the cleanup event runs we're pointing to the correct place

codecov[bot] commented 1 year ago

Codecov Report

Merging #809 (f1aa6ec) into main (2a51745) will increase coverage by 0.00%. Report is 8 commits behind head on main. The diff coverage is 100.00%.

:exclamation: Current head f1aa6ec differs from pull request most recent head 54196af. Consider uploading reports for the commit 54196af to get more accurate results

@@           Coverage Diff           @@
##             main     #809   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files         525      525           
  Lines        4450     4451    +1     
  Branches      686      686           
=======================================
+ Hits         4393     4394    +1     
  Misses         57       57
Files Changed Coverage Δ
...rc/components/Select/SelectSingle/SelectSingle.tsx 100.00% <ø> (ø)
src/hooks/useRovingTabIndex.ts 97.77% <100.00%> (+0.05%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more