labordynamicsinstitute / qwi_schemas

Unofficial LEHD Schema files
https://lehd.ces.census.gov/data/schema/
Creative Commons Zero v1.0 Universal
1 stars 6 forks source link

Fix industry level for NAICS for 000 #125

Open larsvilhuber opened 5 years ago

larsvilhuber commented 5 years ago

Currently reads:

00 All NAICS Sectors A
000 All NAICS Subsectors A
0000 All NAICS Industry Groups A

should be clarified. Or clarify the labels, or the definition of ind_level.

srt1 commented 5 years ago

I would prefer we had a single code for "All industry" - it could be "00" or "ALL". The three separate codes are a legacy of our original schema, when each csv file had a different layout, and there were three possible industry variables (naicssec, naics3, naics4). With the _industrylevel/industry arrangement, the multiple codes don't really make much sense, since the "all" record is the same, whichever table you are looking at. Also, there is no conceptual reason that the naicssec/naics3/naics4 sit on different csv files - they could all live together, and you would not need to repeat the total, as it is on the internal files. Organizationally it is fine for the PUFs, but the current coding is admittedly screwy.

This issue was identified while we were reviewing the new CIPCODEs for the schema. I am resolving to not go down the same path with that one. We will always use "00" to indicate "all CIPCODEs,"