labordynamicsinstitute / qwi_schemas

Unofficial LEHD Schema files
https://lehd.ces.census.gov/data/schema/
Creative Commons Zero v1.0 Universal
1 stars 6 forks source link

Description on J2JOD earnings measures reversed #72

Closed srt1 closed 6 years ago

srt1 commented 7 years ago

The variable and indicator name are correct, the descriptions of the origin-destination earnings are reversed. There had earlier been a general mixup with these variables, I had to flip everything. It looks like I missed the "App description" in my metadata table.

Correction attached.

variables_j2jod.zip

heathhayward commented 7 years ago

Here is the replacement for the variables_j2japp.csv file for the 4.2b-draft schema. Between this file and Stephen's variables_j2jod.csv file above, this issue should be resolved.

variables_j2japp.zip

larsvilhuber commented 6 years ago

This is fixed. It is an edit of an error in a release, so no new version (as per versioning policy). I will, however, create a new "github release" with a dotted version.

heathhayward commented 6 years ago

Doesn't look like either the j2jod or j2japp csv files were actually fixed/replaced at https://lehd.ces.census.gov/data/schema/V4.2b-draft/variables_j2japp.csv or https://lehd.ces.census.gov/data/schema/V4.2b-draft/variables_j2jod.csv. Did I drop the ball on this by not pushing Chaoling to update these files on the webservers?

srt1 commented 6 years ago

I really don't know...


From: heathhayward notifications@github.com Sent: Monday, December 18, 2017 10:38:00 AM To: labordynamicsinstitute/qwi_schemas Cc: Stephen R Tibbets (CENSUS/CES FED); Assign Subject: Re: [labordynamicsinstitute/qwi_schemas] Description on J2JOD earnings measures reversed (#72)

Doesn't look like either the j2jod or j2japp csv files were actually fixed/replaced at https://lehd.ces.census.gov/data/schema/V4.2b-draft/variables_j2japp.csv or https://lehd.ces.census.gov/data/schema/V4.2b-draft/variables_j2jod.csv. Did I drop the ball on this by not pushing Chaoling to update these files on the webservers?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/labordynamicsinstitute/qwi_schemas/issues/72#issuecomment-352463241, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVlyofAk-WVV8-G217cwxCndWY5Ios0Gks5tBobYgaJpZM4Pvu1E.

larsvilhuber commented 6 years ago

It was implemented in the repository at 1941bc9 . It is available for the usual pull-push workflow in the LEHD repository.

heathhayward commented 6 years ago

OK, I've asked Chaoling to push the update. No further updates are in the repository yet, correct? I don't want to push something that's not ready...

larsvilhuber commented 6 years ago

This was the last commit to the lehd branch, which is the only one being incorporated into Census codebase. So the answer is: No, no further updates.

-- Lars Vilhuber, Economist Cornell University, Executive Director, Labor Dynamics Institute and ILR School - Department of Economics

e: lars.vilhuber@cornell.edu p: +1.607-330-5743 v: https://cornell.zoom.us/my/larsvilhuber w: http://lars.vilhuber.com/ http://lars.vilhuber.com/

Assistant: ldi@cornell.edu | +1.607-255-2744

GnuPG Fingerprint: 0D7D 527F 9268 F693 74BB A666 FD01 37F0 3362 7346


From: heathhayward notifications@github.com Sent: Monday, December 18, 2017 10:47:58 AM To: labordynamicsinstitute/qwi_schemas Cc: Lars Vilhuber; State change Subject: Re: [labordynamicsinstitute/qwi_schemas] Description on J2JOD earnings measures reversed (#72)

OK, I've asked Chaoling to push the update. No further updates are in the repository yet, correct? I don't want to push something that's not ready...

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/labordynamicsinstitute/qwi_schemas/issues/72#issuecomment-352466369, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGsoePYCDbTNbesJxy_LK_l1ZpZG-KKyks5tBokugaJpZM4Pvu1E.

heathhayward commented 6 years ago

The "j2japp.csv" file was implemented into the repository, but the "j2jod.csv" was not (looks like https://github.com/labordynamicsinstitute/qwi_schemas/blob/master/formats/V4.2b-draft/variables_j2jod.csv is still wrong). Lars, can you replace the latter file with the file Stephen provided on October 5 above?

larsvilhuber commented 6 years ago

@heathhayward : this should be fixed now in the LEHD branch. It is available for the usual pull-push workflow in the LEHD repository.

heathhayward commented 6 years ago

this has been implemented on LEHD production.