laboshinl / loam_velodyne

Laser Odometry and Mapping (Loam) is a realtime method for state estimation and mapping using a 3D lidar.
http://wiki.ros.org/loam_velodyne
Other
1.71k stars 952 forks source link

Fix compilation error on Ubuntu 18.04 (ROS Melodic) #105

Closed naoki-mizuno closed 5 years ago

naoki-mizuno commented 5 years ago

Fixes #102. Seems 3.1.3 is the oldest version that supports this option (I couldn't find that option in CMake 3.0.0). Personally I think it's safe to assume that people using Ubuntu 16.04 have CMake 3.1.3 or higher, since 3.2.2 was released in 2015 for Xenial.

Apart from the compilation issue (which is resolved with this PR), I can't seem to run the demo bag file.multiScanRegistration node crashes in extractFeatures. Currently looking into this, but it may be due to some API change in the pcl. https://github.com/laboshinl/loam_velodyne/issues/71#issuecomment-416024816 fixed this issue. I'll submit a PR to update the README, since many people seem to be suffereing from this issue.

naoki-mizuno commented 5 years ago

Thanks for merging!