search

labrador-kennel / http-cors

Middleware for @amphp http-server to handle CORS requests!
https://labrador-kennel.io/docs/http-cors
MIT License
8 stars 7 forks source link

Add ConfigurationBuilder API #11

Closed cspray closed 4 years ago

cspray commented 4 years ago

@enumag what do you think of this for the ConfigurationBuilder API? If this looks ok I'll continue with the testing and implementation.

enumag commented 4 years ago

Looks good. Personally I prefer an anonymous class.

cspray commented 4 years ago

Since #14 impacts the Configuration instance in a breaking manner I'm going to implement that first before continuing with this. Thanks for the feedback.

enumag commented 4 years ago

Agreed. By the way #6 is also breaking if we make some things nullable.

cspray commented 4 years ago

Yea, I'll be sure to include in CHANGELOG and release notes that this is a breaking change.