search

labrador-kennel / http-cors

Middleware for @amphp http-server to handle CORS requests!
https://labrador-kennel.io/docs/http-cors
MIT License
8 stars 7 forks source link

Header Comparison is case sensitive #5

Closed cspray closed 4 years ago

cspray commented 4 years ago

We are comparing headers in a case sensitive manner which could cause potential errors. We should update the comparison to ensure it is case insensitive.

cspray commented 4 years ago

@enumag Was hoping to get some more information on what exactly we're looking for with the case insensitive header comparison. Are we just wanting to do this for the Origin header check or all header checks?

enumag commented 4 years ago

origin headers + allowed headers in OPTIONS I think

cspray commented 4 years ago

Fixed with #24