Introduce a new system for building Configuration instances

labrador-kennel / http-cors

Middleware for @amphp http-server to handle CORS requests!

https://labrador-kennel.io/docs/http-cors

MIT License

8 stars 7 forks source link

Introduce a new system for building Configuration instances #7

Closed cspray closed 4 years ago

cspray commented 4 years ago

The ArrayConfiguration object, while potentially useful (particularly in testing contexts), isn't as user-friendly as we should strive to be. A new Configuration builder module should be created that allows for scalar-type checking and a more developer friendly experience creating configuration.

[x] Do we want to allow loading Configuration instances from the filesystem? (e.g. JSON files)
[x] Allow Configuration::getOrigin to return an array of strings?

cspray commented 4 years ago

@enumag looking at the new builder API and I was wondering if it makes sense for a Configuration to allow multiple Origin URL to be returned instead of just one. What do you think?

enumag commented 4 years ago

@cspray I think it does. You might want to allow CORS requests from multiple domains I think.

cspray commented 4 years ago

Created #14 to address this, thanks.