search

labrocadabro / communitytaught

MIT License
79 stars 31 forks source link

Dark Mode #21

Open tjnaz opened 1 year ago

tjnaz commented 1 year ago

Hi, I'm a fellow #100Dev. I've been using this site a lot to keep track of my progress.

I'd love to contribute to this project by creating a "dark mode" version of the site. I've been watching the issues page of this project for someone either requesting or suggesting for this feature but so far I haven't come across one. I asked Ms. Abro regarding this, and she gave me the "go ahead".

I'm a new developer, in fact this would probably be my first open source contribution. I'll be starting on it ASAP. Any suggestion is welcome. Any help is appreciated.

Looking forward to finishing this. I'm so excited.

labrocadabro commented 1 year ago

Thank you for taking this on!

This project uses Tailwind CSS: https://tailwindcss.com/

I'm not sure if you're familiar with Tailwind or not, but it has support for dark mode: https://tailwindcss.com/docs/dark-mode

By default, Tailwind will apply dark mode based on the user's system preference, so there's no need to add a manual toggle. For this PR, please use that method; it's the simplest as it only requires adding Tailwind classes. (Ideally it should be a hybrid of system preference and manual toggle, but I'd like to leave that for a separate issue after the dark mode is implemented).

tjnaz commented 1 year ago

Thank you for taking this on!

This project uses Tailwind CSS: https://tailwindcss.com/

I'm not sure if you're familiar with Tailwind or not, but it has support for dark mode: https://tailwindcss.com/docs/dark-mode

By default, Tailwind will apply dark mode based on the user's system preference, so there's no need to add a manual toggle. For this PR, please use that method; it's the simplest as it only requires adding Tailwind classes. (Ideally it should be a hybrid of system preference and manual toggle, but I'd like to leave that for a separate issue after the dark mode is implemented).

I'm not familiar with Tailwind but I'm reading on it and it seems quite doable, specially since you want the default functionality which uses the user's system preference.

labrocadabro commented 1 year ago

It's pretty simple once you've worked with it a bit, but if you do run into any issues, you can message me on Discord, happy to talk through it. :)

labrocadabro commented 8 months ago

It's been quite a while since you last posted on this - are you still interested in completing it?

SupaMega24 commented 8 months ago

Hi @labrocadabro . I'd like to take a shot at this issue if it has indeed been abandoned.

labrocadabro commented 8 months ago

It probably has, however community taught is going through some changes. The site is going to be integrated into the 100Devs website and one of the things I want to do is make the design of CT consistent with the main site. For that reason, I'm putting a hold on any design changes for now, as they'll probably need to be redone anyway.