search

labrocadabro / communitytaught

MIT License
78 stars 31 forks source link

feat: Collpase homework with dl/dt/dd tags #39

Closed coltonehrman closed 7 months ago

coltonehrman commented 8 months ago

Closes #7

Added dl dt dd tags to homework page to collapse each row into an accordion.

collapsed-homework

labrocadabro commented 8 months ago

lol you're not going to leave anything for anyone else to do, are you? 😆

This actually isn't the solution I wanted, unfortunately. I know this is the suggestion that was made, but as I mentioned in the issue, what I'd like to do is have the homework page have two tabs, Outstanding and Completed (or something to that effect). Or have completed homework move to the bottom of the list. We could, however, also have the homework items be collapsible (I can see a situation where someone wants to skip over certain homework for a while and would like to hide it in the meantime). But if we do that, it needs two features: 1) all homework is expanded by default, and 2) the user's expand/collapse preference for each homework item needs to be remembered, so we'd need DB changes.

I'm going to update the issues to reflect that there are two possible feature improvements (somehow segregating the completed items, and making homework collapsible). If you'd like to go ahead with this one, you can link the PR to the new issue.

I'll leave this open for the moment until you decide if you'd like to go ahead with it or not.

labrocadabro commented 7 months ago

Closing this as there's been no further activity.