search

labrocadabro / communitytaught

MIT License
78 stars 31 forks source link

Collapse Homework #40

Open labrocadabro opened 8 months ago

labrocadabro commented 8 months ago

Make the homework collapsible. The two requirements are:

1) All homework must be expanded by default. 2) The users expanded/collapsed preferences must be remembered for each homework item.

It might also be useful to add an expand/collapse all button, but this is optional.

coltonehrman commented 8 months ago

I feel like having the homework collapsed by default makes sense. As the main issues is "hard to scroll". By having it collapsed by default, that fixes that issue. We can have a "nice to have" feature that is to expand the "active" homework by default. But, honestly I feel like that should belong in the /dashboard as that is what highlights the active class.

labrocadabro commented 8 months ago

I think there's an argument to be made for both. Personally I prefer to see everything first and then collapse what I don't want. Some people prefer to look ahead and see what's coming up, some people only want to see what they need to do right away, some people watch most of the videos before going back and doing the work, some people pick and choose the homework they want to do, sometimes going back to finish things they've missed and sometimes just never doing them. I'm not sure there's any option that's going to be the right default for everyone.

I do think this highlights that the expand/collapse all button needs to be a part of this feature though, so at least whatever default is chosen, it can be easily changed for someone who prefers otherwise. But I still prefer expanded by default.

Current homework on the dashboard will help here, as will hiding completed classes. It should make the homework list more manageable, so collapsing will be less important anyway.