search

labrocadabro / communitytaught

MIT License
78 stars 31 forks source link

"Hide" completed homework #41

Open labrocadabro opened 8 months ago

labrocadabro commented 8 months ago

In order to keep uncompleted homework more visible, we should somehow get the completed homework out of the way. The two solutions I can think of are to have two tabs, one for outstanding homework and one for completed, or move completed homework to the bottom of the list.

nmpereira commented 8 months ago

I'd like to do this!

I'm thinking, in terms of work to be done, moving completed hw to the bottom might be a lot easier than making 2 tabs. If you have a preference for the 2 tab solution, I could also do that.

In terms of marking something 'completed', does everything (submitted and individual hw) in a given class need to be ticked before it can be marked as completed?

labrocadabro commented 8 months ago

I'm thinking perhaps we should have a setting for users to choose what behavior they want: submitted and all items completed, just submitted, just all items complete. Plus an additional boolean for tracking extras/push work. But I think a sensible default is it's complete when all items are marked complete and the homework is submitted, with no tracking of extras.

The advantages of the tab solution are less scrolling if you do need to see completed homework and the ability to further subdivide homework (for example, having "in progress" for all homework with incomplete items, but that isn't the homework for the current class you're on). Bu tabs have the disadvantage that sometimes people don't see them, so let's just go with moving to the end for now. If tabs seem necessary/useful at a later point, we can always handle that in a separate issue.