search

labrocadabro / communitytaught

MIT License
78 stars 31 forks source link

YouTube logo addition #50

Open ob-codes opened 8 months ago

ob-codes commented 8 months ago

On all class page ("/class/all"), anchor tag of 'Youtube' in class card may be replaced with Youtube logo for better UX/UI.

image

labrocadabro commented 8 months ago

Good idea! It looks like the icon is already available, the class is .fa-youtube. if you'd like to take this one on, I'm happy to assign you.

ob-codes commented 8 months ago

thanks. I would love to give it a try but for now, I am unable to clone the repo. Getting an RPC failure due to big file size may be. I'll try a few things and comeback.

ob-codes commented 8 months ago

Update: I have successfully set up and run the project on my local machine. Would be raising a PR to add more details to readme.md I think font-awesome icons are not included in the project coz the icons appear like this. Will look more deeply before giving up. :)

image

labrocadabro commented 8 months ago

There's an open issue for adding a guide to getting set up locally. It's already assigned, but feel free to comment with any information you feel should be included.

It seems I made a small mistake - you need to add both the .fab and .fa-youtube classes for the icon to show.

For better accessibility, the link should include both the icon and the text.

ob-codes commented 7 months ago

thanks for the lead. I was trying classes 'fa fa-youtube' but was not getting the result. For now its looking like this.

image

labrocadabro commented 7 months ago

Great, if you can just add the text back in along with the icon, you can submit the PR and I'll get it merged. :)