search

labrocadabro / communitytaught

MIT License
78 stars 31 forks source link

Run Cypress test with GitHub actions #54

Open nmpereira opened 7 months ago

nmpereira commented 7 months ago

Since we have cypress testing, we should make it more visible to the people making PRs. By adding a github actions file, you can run cypress tests on a PR

Example: Its not cypress tests, but here's an example of a repo thats running jest tests on a push to a PR: https://github.com/CommunityFocus/cf-frontend/blob/main/.github/workflows/main.yml

Additionally, we can add linting/formatting and any other github actions

labrocadabro commented 7 months ago

Github actions are on my to-do list, particularly getting the tests running automatically.

Linting & formatting are also good ideas. I'd also like to set up EditorConfig/ESLint/Prettier config files.

labrocadabro commented 7 months ago

Wasn't really clear on what to do here. This needs to be done, for sure. It's not going to happen immediately though, because part of the integration into the 100Devs website will be moving to a repo within the org. I'll pause this one until the move is complete. At that point, my immediate goal will be to deal with all the issues surrounding contributions and collaboration.

nmpereira commented 7 months ago

This might not need to be paused as moving the repo to another org will make no difference to github actions. It would involve something like adding a yml file to a .github/workflows folder.

I could take this on if you decide to go ahead with it.

example:

https://github.com/Together-100Devs/Together/blob/main/.github/workflows/review-pull-request.yml

labrocadabro commented 7 months ago

This issue is that I'm not sure if the repo will be transferred or if we'll be creating a new one. Transferring (from what I've read) would require me to have permission to create a repository and I'm not sure if that will be the case.

I do appreciate your offer, but I'd like to take this one one myself. I want the practice. :)

labrocadabro commented 7 months ago

Wow my reading comprehension is terrible these days. I realize now that you were saying that Github actions are file-based (something I actually knew 🤦‍♀️ ). Still leaving it paused for the moment because I do want to handle it myself and I've got some other tasks I need to complete first.