queue_data is stored as a QtObject under pyqt4 - Githubissues

labscript-suite-oldfinal1 / blacs

BLACS, part of the labscript suite, provides an interface to hardware used to control a buffered experiment. It manages a queue of shots to be run as well as providing manual control over devices between shots.

Other

1 stars 1 forks source link

queue_data is stored as a QtObject under pyqt4 #26

Closed philipstarkey closed 7 years ago

philipstarkey commented 7 years ago

Original report (archived issue) by Jan Werkmann (Bitbucket: PhyNerd, GitHub: PhyNerd).

If someone currently updates BLACS will start up throwing a error of PyQt4 not being imported if there was a file in the queue on the last close. This is unfortunate as we need to implement a temporary fix for this or some percent won't be able to use BLACS after update.

I'll try to add some try catches and create a pull request in the next few minutes after i verified it works.

philipstarkey commented 7 years ago

Original comment by Jan Werkmann (Bitbucket: PhyNerd, GitHub: PhyNerd).

the problem was caused by line 157 in queue.py. But changing this now won't help so as I said I'll write some try catch clauses in main.py where saved data is used.

philipstarkey commented 7 years ago

Original comment by Jan Werkmann (Bitbucket: PhyNerd, GitHub: PhyNerd).

So I created a pull request to fix the issue but we should check if we need to fix the cause in a later update as well.

The fix is tested on the machine that had the problem and works.

Update: checked and under qtutils2/QtAPIv2 queue_data is stored as string so no need for further fixing

philipstarkey commented 7 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

changed state from "new" to "resolved"

Fixed by pull request #16

philipstarkey commented 7 years ago

Original comment by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).

When we release the next version of BLACS we should make an announcement on the mailing list and make sure to mention that the contents of the Queue will be lost then (since the fix is just to throw everything in the queue away)