search

labscript-suite-oldfinal1 / blacs

BLACS, part of the labscript suite, provides an interface to hardware used to control a buffered experiment. It manages a queue of shots to be run as well as providing manual control over devices between shots.
Other
1 stars 1 forks source link

Consoles don't remember their size or popped-outness #47

Closed philipstarkey closed 6 years ago

philipstarkey commented 6 years ago

Original report (archived issue) by Lincoln Turner (Bitbucket: lincolndturner, GitHub: lincolnturner).

The new BLACS console feature is great, but after a worker restart or BLACS restart the console disappears again. It is readily retrieved, but ideally BLACS would remember the console geometry inside each tab.

philipstarkey commented 6 years ago

Original comment by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).

That's a bug! The code is there to do this, but it doesn't get called properly.

philipstarkey commented 6 years ago

Original comment by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).

@lincolnturner I made a pull request for the fix.

philipstarkey commented 6 years ago

Original comment by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).

Fixed a bug where the save data for the console was not being stored on tab restart.

We now have a new method in the Tab bas class called get_all_save_data() which collates the save data from Tab.get_builtin_save_data and the get_save_data method of a subclass (if it exists). We also fix a bug which causes blacs to crash on exit if the return value of get_save_data() was not a dictionary. We also change the order in which the dictionary gets updated so that subclasses can override the restore behaviour of the worker terminal if they wish (but it's discouraged via the use of the underscore prepending the dictionary keys). The front panel settings saving code is also now simplified to make use of these changes!

This fixes issue #47 and results in a bump of the patch version to 2.3.1

→ \<\<cset c3d158772eeb5f328414b382bc0320e41aacc6cb>>