search

labscript-suite-oldfinal1 / installer

The installer for the labscript suite. This repository is used used to build zip files containing an install script and all the labscript suite python packages.
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

importlib_metadata package should be added to the required dependencies #29

Closed philipstarkey closed 5 years ago

philipstarkey commented 5 years ago

Original report (archived issue) by Philip Starkey (Bitbucket: philipstarkey, GitHub: philipstarkey).

I just did a fresh install under Python 3.7 and ran into an error because I had not installed the importlib_metadata package from PyPi. This should be added as a required dependency so the installer doesn’t crash half-way through.

philipstarkey commented 5 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

Partial duplicate of labscript_utils issue #25 (labscript-suite/labscript_utils#25). I'm on it!

I'll have to special case the dependency because importlib_metadata will be part of the standard library in Python 3.8.

philipstarkey commented 5 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

Fixed in PR #15

philipstarkey commented 5 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).