dragdroptabs behave strange - Githubissues

labscript-suite-oldfinal1 / labscript_utils

Shared modules used by the labscript suite. Includes a graphical exception handler, debug tools, configuration management, cross platform filepath conversions, unit conversions and custom GUI widgets.

Other

0 stars 0 forks source link

dragdroptabs behave strange #13

Closed philipstarkey closed 7 years ago

philipstarkey commented 7 years ago

Original report (archived issue) by Jan Werkmann (Bitbucket: PhyNerd, GitHub: PhyNerd).

If I try and drag a inactive tab that works as long as I stay in the same tab container. Once I drag it out the dragged tab is suddenly switched and I'm dragging the selected tab.

It would be better id the dragged Tab stays the same.

philipstarkey commented 7 years ago

Original comment by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).

Sorry, I think I'm not understanding. I tried to reproduce quickly but couldn't so I must be missing something. Could you elaborate? (code/pictures appreciated!)

philipstarkey commented 7 years ago

Original comment by Jan Werkmann (Bitbucket: PhyNerd, GitHub: PhyNerd).

sure I'm trying to drag bar in the gif. But suddenly it is foo that I'm dragging. I did not release the mouse button at any time.

philipstarkey commented 7 years ago

Original comment by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).

Can't reproduce this on windows. Could be a OSX specific issue?

philipstarkey commented 7 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

So in Windows and Linux the initial click on 'bar' would have made it active, meaning the dragged tab would always be the active one. It seems in macos that this is not the case.

philipstarkey commented 7 years ago

Original comment by Jan Werkmann (Bitbucket: PhyNerd, GitHub: PhyNerd).

It's not a problem in that case as most probably no one is using mac os to actually run labscript. It was just something I noticed when doing the Qt5 port.

philipstarkey commented 7 years ago

Original comment by Jan Werkmann (Bitbucket: PhyNerd, GitHub: PhyNerd).

changed state from "new" to "resolved"

Fixed as of commit 45ce1230d45fada27cf8b884cd8920bd444ef92a