New Folder for each engage

[philipstarkey]

Original report (archived issue) by Jan Werkmann (Bitbucket: PhyNerd, GitHub: PhyNerd).

---

In our lab we commonly run a series of a few hundred shots, then tweak a few globals and run that series again. This generates a lot of h5 Files and since not all series workout, we sometimes want to delete a whole series in bundle. Currently this is quite cumbersome since we need to finde the files, that belong to one shot in the many hundreds of files generated that day.

I propose creating a new Folder each time engage is clicked by changing the make_h5_files function in the following way:

#!python
    def make_h5_files(self, labscript_file, output_folder, sequence_globals, shots, shuffle):
        sequence_id = runmanager.generate_sequence_id(labscript_file)
        output_folder = os.path.join(output_folder, sequence_id.split('T')[1].split('_')[0])
        mkdir_p(output_folder)  # ensure it exists
        run_files = runmanager.make_run_files(output_folder, sequence_globals, shots, sequence_id, shuffle)
        logger.debug(run_files)
        return labscript_file, run_files

[philipstarkey]

Original comment by Jan Werkmann (Bitbucket: PhyNerd, GitHub: PhyNerd).

---

• Edited issue description

[philipstarkey]

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

---

This is a change already implemented in the Spielman fork of runmananger, which I'm planning on merging in to the mainline soon.

It's based on an incrementing integer (which I also like) rather than using the timestamp, but is otherwise much the same.

We might support both methods, but I think a single folder per sequence is pretty clearly superior, so if others agree about this it will probably just replace the current way things work.

[philipstarkey]

Original comment by Jan Werkmann (Bitbucket: PhyNerd, GitHub: PhyNerd).

---

Sounds great I'm looking forward to it and until then my quick fix will do the trick.

[philipstarkey]

Original comment by Russell Anderson (Bitbucket: rpanderson, GitHub: rpanderson).

---

• changed state from "new" to "resolved"

Resolved by pull request #30.