search

labscript-suite-oldfinal1 / runmanager

runmanager is a graphical user interface (GUI) used to aid the compilation of labscript experiment scripts into hardware instructions to be executed on the hardware. Experiment parameters can be adjusted in the GUI, and lists of parameters can be used to create sequences of experiments, and scan over complex parameter spaces.
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

ModuleWatcher notices changes to runmanager module #53

Open philipstarkey opened 6 years ago

philipstarkey commented 6 years ago

Original report (archived issue) by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).

The ModuleWatcher module (created inside the batch compiler) seems to notice changes to runmanager and indicates it will reload runmanager/__init__.py. This occurs if you update runmanager via mercurial while runmanager is running.

This is probably undesirable since the batch compiler doesn't get explicitly reloaded, but the runmanager API inside batch compiler does get reloaded. This may lead to incompatibilities between the two.

I think this may be a result of pull request #18.

Note: There are already existing issues with ModuleWatcher, see issue #28.

philipstarkey commented 6 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

Huh. moduleWatcher is supposed to whitelist all modules that are imported at the time it is instantiated, and runmanager.batch_compiler was imported in batch_compiler_labscript.py, which would have imported runmanager, so it shouldn't have been unloaded.

This seems to be a different problem to issue #28, which is about it whitelisting too much.

philipstarkey commented 6 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

I'm not able to reproduce this.