Cannot create globals in recent Python releases

labscript-suite-oldfinal1 / runmanager

runmanager is a graphical user interface (GUI) used to aid the compilation of labscript experiment scripts into hardware instructions to be executed on the hardware. Experiment parameters can be adjusted in the GUI, and lists of parameters can be used to create sequences of experiments, and scan over complex parameter spaces.

BSD 2-Clause "Simplified" License

0 stars 0 forks source link

Cannot create globals in recent Python releases #65

Closed philipstarkey closed 5 years ago

philipstarkey commented 5 years ago

Original report (archived issue) by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

The following 'bugfix' to Python's tokenizer module broke runmanager's checking of whether a global is a valid Python variable name:

https://bugs.python.org/issue33899

This breaks runmanager for Python 3.7.1 and 3.6.6, released in October 2018. They even backported it to Python 2.7 but reverted it before releasing, so it doesn't affect Python 2.

Anyhow I'll fix it in runmanager.

philipstarkey commented 5 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

changed state from "new" to "resolved"

Merged in bugfix (pull request #31)

Fix issue #65 - cannot create globals in latest Python releases.

→ \<\<cset 7ea19b053078fc6d94bdc381af63b23bf910b270>>

philipstarkey commented 5 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

Fix issue #65 - cannot create globals in latest Python releases.

The issue was caused by a change in the behaviour of the tokenize module when the source being tokenized does not end in a newline character.

See https://bugs.python.org/issue33899

→ \<\<cset b5b60cf859a370cd026b29f431b19a41e4341c7f>>

philipstarkey commented 5 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

Merged in bugfix (pull request #31)

Fix issue #65 - cannot create globals in latest Python releases.

→ \<\<cset 7ea19b053078fc6d94bdc381af63b23bf910b270>>