instruction times should be quantised to the pseudoclock clock_resolution

labscript-suite-temp-2 / labscript

The labscript Python library provides a translation from simple Python code to complex hardware instructions. The library is used to construct a "connection table" containing information about what hardware is being used and how it is interconnected. Devices described in this connection table can then have their outputs set by using a range of functions, including arbitrary ramps.

BSD 2-Clause "Simplified" License

0 stars 0 forks source link

instruction times should be quantised to the pseudoclock clock_resolution #40

Closed philipstarkey closed 7 years ago

philipstarkey commented 7 years ago

Original report (archived issue) by Shaun Johnstone (Bitbucket: shjohnst, GitHub: shjohnst).

As per pull request #11, there is a bug where the 'extra clock tick' that can be inserted just before a break in a ramp* may be shortened incorrectly (and thus tick faster than the allowed clock_limit rate of an attached ClockLine) due to the quantisation of the pseudoclock.

EDIT: This was reported by @philipstarkey (@shjohnst was just logged into the PC)

* The break in ramps is a result of labscript automatically splitting ramps when another output needs to be updated during the middle of a ramp

philipstarkey commented 7 years ago

Original comment by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).

Edited issue description

philipstarkey commented 7 years ago

Original comment by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).

Edited issue description* changed title from "instruction times should be quantised to the pseudoclock clock_limit" to "instruction times should be quantised to the pseudoclock clock_resolution"

philipstarkey commented 7 years ago

Original comment by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).

changed state from "new" to "resolved"

fixes issue #40

We now quantise all times to multiples of the pseudoclock clock_resolution.
changed some error messages to report times, and to report the times to more significant figures so it is easy to see if the discrepancy comes from floating point rounding error)
Added a method to Device which allows you to quantise times based on the clock_resolution of the parent pseudoclock device.

→ \<\<cset 48143b37de24019e84a36ba3a4c1292c7a6a2660>>