labscript-suite-temp-2 / labscript

The labscript Python library provides a translation from simple Python code to complex hardware instructions. The library is used to construct a "connection table" containing information about what hardware is being used and how it is interconnected. Devices described in this connection table can then have their outputs set by using a range of functions, including arbitrary ramps.
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

pseudoclock wait_delay is probably not respected #50

Open philipstarkey opened 5 years ago

philipstarkey commented 5 years ago

Original report (archived issue) by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).


As per the comment chain in this pull request over on the labscript_devices repository, I suspect that the wait_delay attribute of secondary pseudoclocks is not being respected, and thus the master pseudoclock may not wait a sufficient time before emitting a trigger pulse to resume the shot.

This would result in secondary pseudoclocks becoming out of sync with the primary, which may explain the occasional dropped shots seen in the monash spinor BEC lab.

We should check to see if it is easy to fix in labscript 2, or if we need to wait until labscript 3 in order to correctly offset instruction times for secondary pseudoclocks.